Giters

levibostian / semantic-release-precheck

semenatic-release plugin to perform a pre-check for an existing deployment before attempting a new one

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve logs after running is-it-deployed

levibostian opened this issue · comments

commented

Just ran a deployment with this plugin.

I found this confusing:

...
[2:01:47 PM] [semantic-release] [semantic-release-precheck] › ℹ  Checking if version 2.0.0-beta.1 of package semantic-release-precheck is already deployed to npm.
[2:01:47 PM] [semantic-release] [semantic-release-precheck] › ℹ  Running publish for deployment plugin: @semantic-release/npm
...

I would have expected:

...
[2:01:47 PM] [semantic-release] [semantic-release-precheck] › ℹ  Checking if version 2.0.0-beta.1 of package semantic-release-precheck is already deployed to npm.
[2:01:47 PM] [semantic-release] [semantic-release-precheck] › ℹ  Version 2.0.0-beta.1 of package semantic-release-precheck has not been deployed. Will continue running deployment plugin: @semantic-release/npm
[2:01:47 PM] [semantic-release] [semantic-release-precheck] › ℹ  Running publish for deployment plugin: @semantic-release/npm
...

Also later on after the publish completes:

...
[2:01:49 PM] [semantic-release] [semantic-release-precheck] [@semantic-release/npm] › ℹ  Published semantic-release-precheck@2.0.0-beta.1 to dist-tag @beta on https://registry.npmjs.org/
[2:01:49 PM] [semantic-release] [semantic-release-precheck] [@semantic-release/npm] › ℹ  Checking if version 2.0.0-beta.1 of package semantic-release-precheck is already deployed to npm.
[2:01:49 PM] [semantic-release] › ✔  Completed step "publish" of plugin "semantic-release-precheck"
...

I would have expected:

...
[2:01:49 PM] [semantic-release] [semantic-release-precheck] [@semantic-release/npm] › ℹ  Published semantic-release-precheck@2.0.0-beta.1 to dist-tag @beta on https://registry.npmjs.org/
[2:01:49 PM] [semantic-release] [semantic-release-precheck] [@semantic-release/npm] › ℹ  Confirming that version 2.0.0-beta.1 of package semantic-release-precheck got deployed to npm successfully.... I will fail the deployment if version cannot be found on npm to indicate that the deployment had a problem. 
[2:01:49 PM] [semantic-release] [semantic-release-precheck] [@semantic-release/npm] › ℹ  Success! Version 2.0.0-beta.1 of package semantic-release-precheck found on npm! 
[2:01:49 PM] [semantic-release] › ✔  Completed step "publish" of plugin "semantic-release-precheck"
...