lessthanoptimal / ejml

A fast and easy to use linear algebra library written in Java for dense, sparse, real, and complex matrices.

Home Page:https://ejml.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reduced Row Echelon Form Bug

KayakDov opened this issue · comments

The following code does not yield reduced row echelon form.

DMatrixRMaj matrix = new DMatrixRMaj(2, 3, true, new double[]{0,2,2,0,0,2});
System.out.println(CommonOps_DDRM.rref(matrix, -1, null));

Prints:
Type = DDRM , rows = 2 , cols = 3
0.0000E+00 1.0000E+00 1.0000E+00
0.0000E+00 0.0000E+00 2.0000E+00

but the first non zero element on each row should be 1.

Deleted first reply since I can't apparently read. Looking into this.

Fixed the issue. Combination of bad test coverage of bad default value for number of columns. Thanks for pointing out the problem. I'm surprised this went unnoticed for so long!

#130

Also apologies for taking so long to look into this and missing it in the last release.