leehanchung / cs224n

Stanford CS224n: Natural Language Processing with Deep Learning, Winter 2020

Home Page:https://web.stanford.edu/class/cs224n/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

missing relu at line 57 in cnn.py in a5_public

yagebu90 opened this issue · comments

Hi, nice sharing. A small typo in calculating the final output X_{conv_out} of convolutional network. According to equation (7) of a5.pdf, there should be a relu before implementing maxpool.