ledermann / docker-rails

Dockerize Rails 7 with ActionCable, Webpacker, Stimulus, Elasticsearch, Sidekiq

Home Page:https://docker-rails.ledermann.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request: Add support for running the project in a development container in VS Code

Juice10 opened this issue · comments

vscode has the ability to add a configuration that will allow you to run your rails environment in a development container: https://code.visualstudio.com/docs/remote/create-dev-container
It would be great to add support for that.

@ledermann I do have a dev config, would you be open for a PR?

@zernie I don't use Docker for development because the last time I tried it (a long time ago) there were lots of issues. If it's useful these days, I'd be happy to see a PR.

@zernie I don't use Docker for development because the last time I tried it (a long time ago) there were lots of issues. If it's useful these days, I'd be happy to see a PR.

btw I use https://github.com/ufoscout/docker-compose-wait for awaiting services. Would you be open to replacing your scripts with this tool as well (in a separate PR)?

@zernie Regarding docker-compose-wait: I'm not convinced that including this would perform better than the existing wait-for-services.sh script. It works very well and uses just netcat which already exists in the Alpine image.

@ledermann docker compose wait also uses netcat:) but it is also much easier to extend for new services and provides some very useful config vars