leastbad / optimism

The missing drop-in solution for realtime remote form validation in Rails.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

maybe *$stdout*... is more accurate

pulgamecanica opened this issue · comments

commented

$stderr.puts "=> #{channel[:app_path]} created"

....
I just wanted to point out that it might be more accurate to use $stdout... Im just a noob and I know it doesn't changes any functionality... haha I was just having a look at the cool Ruby files.
I will delete this issue soon because it's not an issue..... haha I just felt like sharing this....

Hi Andre! Welcome and don't ever apologize for posting suggestions in good faith.

Soooo, I did a git blame and this functionality was contributed by @andrewmcodes, who is no slouch but also is in a better position to explain why he chose to use $stderr.

hm I’m not sure why I choose $stderr since that is typically reserved for exceptions. I must have copied and pasted some code without thinking about it too much. You’re correct that $stdout would be semantically more “correct” though I’m not sure the actual implementation would change much.

PR’s accepted.

@pulgamecanica it seems like you could make a PR......... 💯

commented

Amazing, I feel so honored, this will be my very first "contribution" as little as it is, but Im very happy! :)

Just to be clear, it's us that is lucky to entertain someone's first PR. Bravo, friend!