Giters

learnyouahaskell / learnyouahaskell.github.io

A community version of the renowned "Learn You a Haskell" (LYAH) tutorials collection!

Home Page:https://learnyouahaskell.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace Comments about BMI

andrewthad opened this issue · comments

commented

The syntax-in-functions page includes a BMI example that may benefit from being rewritten. The two options I'm aware of would be:

  • Keeping using BMI as the example, but change the messages for different categories
  • Change the example to something else that uses division, perhaps calculating speed from distance and time, and then it would be possible to provide silly messages that aren't about a sensitive issue.

I prefer the second option because I think it would just be best to avoid discussing BMI. I am happy to put together a PR if the maintainer agrees.

commented

@andrewthad Thanks for pointing this out! Yes, please feel free to fork and submit a PR. Pull requests are always welcome. ( and preferred 😇 )

commented

@andrewthad you mentioned you were interested in submitting a PR. I think it would be a great improvement. I just bumped into another SO question about this terrible example.

I'm leaning towards your option 2 (do away with BMI altogether).