learningequality / kolibri-installer-gnome

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Links with target=_blank open outside Kolibri

dylanmccall opened this issue · comments

Kolibri sometimes has links with target=_blank, such as in the "Coach" section before any classes have been created:

Screenshot from 2020-08-12 15-50-21

Clicking one of these links in the app opens the default web browser. Instead, links like these (internal links which don't look like file downloads) should always open in the app, in the current window.

Note that this particular behavior is actually a regression - opened a new issue here: learningequality/kolibri#7480

After that regression is fixed, we may need to revert #8 because there will actually be other scenarios where _blank links are intended to open in an external web browser, for example:

2020-08-17 17 50 41