leanprover-community / mathlib4

The math library of Lean 4

Home Page:https://leanprover-community.github.io/mathlib4_docs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Porting note: unimplemented instance_priority linter

grunweg opened this issue · comments

This issue is tracking all porting notes referring to the instance_priority linter from mathlib3:
as this linter has not been ported to mathlib4 yet, the nolint entries from mathlib3 are commented. Porting notes look like

-- @[nolint has_nonempty_instance] -- Porting note: This linter does not exist yet.

Steps to fix

  • port the linter
  • see which of the previous nolints are required: uncomment the necessary ones and delete the now-superfluous ones.
    Remove the porting note in either case.
  • deal with any new errors in mathlib4
  • land the linter and rejoice :-)

Note. There are just five such porting notes. Perhaps this issue can also serve as a tracking issue for this particular linter.