fix github image

Question

fix github image

lcrojano opened this issue 8 months ago · comments

Luis Carlos Rojano commented 8 months ago

Issue Description:

The GitHub icon is not loading.

Possible Solution

To fix this issue, you can consider one of the following solutions:

Modify the image source from src="/assets/images/github-mark-white.png" to src="assets/images/github-mark-white.png" (remove the leading '/').
or

Update the image source to a direct path to the file, like this: GitHub Icon. you should use "https://raw.githubusercontent.com/username/repository/branch/path/to/file"

Please make the necessary adjustments to ensure the GitHub icon loads correctly.
Screenshot

This is intended to be a short issue.

Luis Carlos Rojano · Answer 1 · Fri Oct 27 2023 10:37:11 GMT+0800 (China Standard Time)

Hi there, are you interested in working on this issue? @CapedCrusader

Tapan Dabhi · Answer 2 · Fri Oct 27 2023 12:46:39 GMT+0800 (China Standard Time)

Hi @lcrojano assign it to me

Tapan Dabhi · Answer 3 · Fri Oct 27 2023 12:58:23 GMT+0800 (China Standard Time)

@lcrojano added mr here #40

Roldex Stark · Answer 4 · Fri Oct 27 2023 22:16:57 GMT+0800 (China Standard Time)

The GitHub icon is not being loaded because it is st up as a relative path.

Possible Solution

You could fix it by adding a direct path to the file: https://github.com/lcrojano/Giphy_Explorer/blob/main/assets/images/github-mark-white.png

Screenshot

@CapedCrusader

this url cant be used as a source

Tapan Dabhi · Answer 5 · Fri Oct 27 2023 23:38:55 GMT+0800 (China Standard Time)

@r0ld3x my MR has the correct URL.

Luis Carlos Rojano · Answer 6 · Sat Oct 28 2023 00:18:42 GMT+0800 (China Standard Time)

Hi! The pull request was created to help newcomers achieve their first commit for Hacktoberfest. It was specifically created for @CapedCrusader. If we don't receive a response or if no longer interested in solving this issue within a couple of days, we will accept the first pull request.

to fix the issue you could remove the "/"

<img src="/assets/images/github-mark-white.png" alt="GitHub">
to
<img src="assets/images/github-mark-white.png" alt="GitHub">

Also, I've created #42 so anyone can work on this new issue.

Deleted user · Answer 7 · Tue Oct 31 2023 01:53:33 GMT+0800 (China Standard Time)

Hi! The pull request was created to help newcomers achieve their first commit for Hacktoberfest. It was specifically created for @CapedCrusader. If we don't receive a response or if no longer interested in solving this issue within a couple of days, we will accept the first pull request.

to fix the issue you could remove the "/"

<img src="/assets/images/github-mark-white.png" alt="GitHub">

to

<img src="assets/images/github-mark-white.png" alt="GitHub">

Also, I've created #42 so anyone can work on this new issue.

Sorry for the late reply @lcrojano yes i would love to work on this issue😇