LBRY crashes to desktop when trying to upload on Windows 7 starting at v0.5.36
Sessh22 opened this issue · comments
Basically, when trying to upload a file at the upload screen, either using the Browse button to select a file via explorer or using drag-n-drop on the file results in the app crashing to desktop. This doesn't happen on 0.5.35, but does on 0.5.36 and 0.5.37.
To repro:
- go to your uploads and click the "Upload" button
- click "Browse" in the file box and select a file or drag and drop a file to upload
- app crashes a few seconds later
Of course, expected behavior is the file is accepted and the app functions normally.
- LBRY Daemon version: 0.110.0
- LBRY App version: 0.5.36 / 0.5.37
- LBRY Installation ID: 6MWuUBTneBsyYMS4VJtwNyU3KWX6mT5oEoUJGMoxg4gprTjGN3DkeWGMiHWVFiCUhP
- Operating system: Windows 7 SP1
I do see that in 0.5.36, there's an entry for "fixed various upload bugs including transcoding" which might be significant.
I have the same issue in Linux (Fedora 37) . This bug happens when the file is large. Even with smaller file, such as a few mb short video, you can clearly feel that the lbry-desktop app is freezing for a few seconds.
Can you specify:
- whether you're checking transcoding
- size/format of file
- whether you have "preview" enabled so you see the confirm/upload modal?
- Not using transcoding
- 720p MP4 (h.264) / files are large between 500MB - 1GB and are 4+ hours long. Weekly uploader.
- I do see the preview/confirm upload screen
- Not checking the transcoding.
- 1 to 1.5 GB, 1 to 1.5 hours long, formats are MP4 H.264, WEBM VP9 (both crashed).
- I have "preview enabled", but different from Sessh22, I can't even see the preview window. Right after selecting the file, the app would freeze and then crash in seconds. I can't even click the submit button.
Perhaps I misunderstood. I have the preview enabled, but I get nowhere near being able to see it because as already stated, the app crashes a few seconds after selecting the file to upload. I thought he was asking if I had it enabled at all. I figured it was already assumed I wasn't actually seeing it because the app crashed almost immediately after selecting the file. Sorry for the confusion.
My situation is identical to yours, IceGuye. Jessopb replied saying disk usage spikes to 100% and that he's looking into it which is what my email reply was in response to, but his post stating that didn't show up here for some reason. :)
I've reproduced the problem. It is described in the limitations section of this link:
https://www.npmjs.com/package/get-file-object-from-local-path
I'll have a fix out today or tomorrow. The disk usage spikes were not the problem - that was my old windows vm.
Great I'll be sure to test that out when it's available.
PR is ready, but we have a release issue I'm waiting for.
The alpha release with the fix is in releases now!
I grabbed it and it now lets me select a file and everything appears to be normal. I can get to the preview screen now and did everything except push it through. Looks good!
IceGuye can hopefully test on his Linux box as well just to be sure.
Tested on the last git pull. I can upload in Linux now.
yay!