Giters

lbenthins / ecu-simulator

Tool that simulates some vehicle diagnostic services. It can be used to test OBD-II dongles or tester tools that support the UDS (ISO 14229) and ISO-TP (ISO 15765-2) protocols.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong behaviour for "READ_DTC_INFO_BY_STATUS_MASK"

sigttou opened this issue · comments

commented

From my understanding the len(request) should be at least 3, no? I am not sure, as I do not have the exact specification at hand.

Looking at the implementation of udsoncan, the 0x19 service always takes an additional parameter, the status mask for the function 0x2(READ_DTC_INFO_BY_STATUS_MASK).

I think, therefore, there's an error in the function get_0x19_response for handling READ_DTC_INFO_BY_STATUS_MASK.

Hope this is a correct mistake, otherwise I will report a bug at udsoncan.