Failure to compile with flags Werror=unused-result and Werror=unused-but-set-variable

Question

Failure to compile with flags Werror=unused-result and Werror=unused-but-set-variable

flounders opened this issue 9 years ago · comments

Steven Michael Williams commented 9 years ago

The affected files are libs/core/log/log.c, libs/common/error.c, libs/signet/keys.c. I adjusted the code to make it compile, but I am unsure that my code matches the intended behavior of the function. If you are interested I can submit a patch or pull request.

Ivan · Answer 1 · Fri Jun 26 2015 00:18:52 GMT+0800 (China Standard Time)

We're definitely interested in a pull request to see what it was that was broken.

Steven Michael Williams · Answer 2 · Fri Jun 26 2015 02:38:37 GMT+0800 (China Standard Time)

Here is the pull request: #24

Steven Michael Williams · Answer 3 · Wed Jul 15 2015 10:07:38 GMT+0800 (China Standard Time)

I just tried testing this again before closing the issue, but with the latest commit in the master branch it will not compile on line 245 of libs/common/error.c. The typecast to void does not seem to be taking care of compiler warning.

Steven Michael Williams · Answer 4 · Mon Aug 10 2015 07:47:17 GMT+0800 (China Standard Time)

The develop branch no longer has this problem.

Zachary Michaels · Answer 5 · Tue Aug 11 2015 00:38:20 GMT+0800 (China Standard Time)

As a note, part of the issue here was that the GNU-specific version of strerror_r returns a char * instead of the integer specified by POSIX. We're now using autoconf to check and handle both cases. (The OS X build does not use the GNU version.)