Binning Summation

Question

Binning Summation

pbonazzi opened this issue 10 months ago · comments

Can you clarify this binning mode summation?
Shouldn't we use torch.index_add_ ? Otherwise there is no difference between binningmode SUM and OR

https://github.com/lava-nc/lava-dl/blob/185edfe9fb035e13c24eec063a4971ccb0956d3a/src/lava/lib/dl/slayer/io.py#L234C1-L241C38

bamsumit · Answer 1 · Mon Sep 25 2023 22:56:03 GMT+0800 (China Standard Time)

Hi @pbonazzi I am guessing you are meaning to say SUM mode and OR mode. Yes the current implementation seems to be a bug. Would you like to make a correction PR?

Pietro Bonazzi · Answer 2 · Thu Sep 28 2023 12:47:58 GMT+0800 (China Standard Time)

Yes, I can do it over the weekend.