Linux: non hidden Last.fm folder created in home directory
Fuchs opened this issue · comments
Since updating to liblastfm 1.0.8 every time I run an application using it (amarok), it creates a non-hidden folder Last.fm in my home directory.
Downgrading to liblastfm 1.0.7 solves this issue.
Could you please either create a hidden folder or use ~/.config/ instead, as other applications and libraries do?
Thank you in advance :)
Steps to reproduce:
- update to liblastfm 1.0.8
- run an application that uses liblastfm, example: amarok
- a new folder "Last.Fm" is created in your home directory
Software used:
Gentoo Linux on x86_64, liblastfm seems to compile against Qt 4.8.5 (got Qt5 installed as well)
If you need further information, do not hesitate to contact me. I might be hard to reach during the next couple of weeks, though.
This seems to be caused by the fixes for Qt5 in 50291f6 et al. Problem is that Q_OS_UNIX
(or Q_OS_X11
, but that is fixed in current master) is not defined on Linux systems and you need to check for Q_OS_LINUX
. I have prepared a fix against current master in aursulis/liblastfm@5abf3e0
Do you accept pull requests from non-employees?
By the way you can apply this patch on Gentoo by downloading the following: https://gist.github.com/aursulis/e968a8bc500c9b7179a2/raw/3a26fb77fa72310c32b16ae2edfd27032af0c500/fix-q-os-linux.patch then placing it in /etc/portage/patches/media-libs/liblastfm-1.0.8/
and re-emerging liblastfm
.
Fixed by #27.