Change verbose reporting format for StructuredPerceptron

Question

Change verbose reporting format for StructuredPerceptron

kmike opened this issue 11 years ago · comments

Mikhail Korobov commented 11 years ago

What do you think about

using sum_loss instead of loss (currently the printed loss is a loss for some random sequence) and
printing iteration number at the same line as sum_loss (=> 2x less output lines)?

Lars · Answer 1 · Mon Aug 12 2013 02:48:22 GMT+0800 (China Standard Time)

Indeed, I'll fix this. @kmike, do you want push access to my repo?

Mikhail Korobov · Answer 2 · Mon Aug 12 2013 06:00:19 GMT+0800 (China Standard Time)

@larsmans - I'm not sure what to do with that push access because I don't know where is this project heading to, and also you usually rewrite my PRs in a better way :) Not having push access rights is easier, at least now. But I could push simple fixes myself if you want - thanks for the offer!

Lars · Answer 3 · Mon Aug 12 2013 16:21:21 GMT+0800 (China Standard Time)

You're a collaborator now, so you can push bugfixes. I'd like to discuss bigger changes, but don't wait for perfectionist me to fix stuff that's broken :)