laravel / socialite

Laravel wrapper around OAuth 1 & OAuth 2 libraries.

Home Page:https://laravel.com/docs/socialite

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

New Google sign-in

mikelina opened this issue · comments

On March 31, 2023 Google deprecated the JS Library used for sign-in (https://developers.google.com/identity/sign-in/web/sign-in?hl=en)
The new library (https://developers.google.com/identity/gsi/web/guides/overview?hl=en) returns a JWT token instead of an access token.
Will you update socialite in order to handle this new feature?

Heya, yeah I think we should migrate to the new way of doing things. This would have to be a PR sent in to master for the next major version.

The guide here can help: https://developers.google.com/identity/gsi/web/guides/migration?hl=en

We'd appreciate any help with this.

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

@mikelina Are you able to make a pull request fixing the issue you have described, along with corresponding tests?

@nunomaduro I'm actively working on an implementation for this. See #636

@CosminBd Thank you! Let's follow up on the discussion on the pull request itself! ✅

Looks like Taylor wants this to be a community driver, sorry.

I do not think that this is an issue for socialite.
socialite is handling OAuth flow, but Google new auth system via Google Identify Service uses JWT auth, so there is no place to new google auth system for socialite package.