laravel / pint

Laravel Pint is an opinionated PHP code style fixer for minimalists.

Home Page:https://laravel.com/docs/pint

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

no_superfluous_phpdoc_tags rule doesn't remove tags with PHP 8 Attributes

EriBloo opened this issue · comments

  • Pint Version: 1.5
  • PHP Version: 8.2

Description:

When Attribute is added to parameter it is not removed from phpdoc even when it could've been. I'm not sure if this is intended behaviour.

Steps To Reproduce:

Before formatting:

    /**
     * @param string $uuid
     * @param CreateData $data
     */
    public function __construct(
        #[AggregateUuid]
        public string     $uuid,
        public CreateData $data
    )
    {
    }

After formatting:

    /**
     * @param  string  $uuid
     */
    public function __construct(
        #[AggregateUuid]
        public string $uuid,
        public CreateData $data
    ) {
    }

(in addition this example will leave phpstorm reporting PHPDoc comment signature is not complete)

Hi there, we only implement the rule of PHP CS Fixer. Please open an issue with them if you think there's an issue. Thanks