[BUG] PrimaryReadReplica doesn't work
gierappa opened this issue · comments
Mateusz Gierach commented
Function hasValidPrimaryReadReplicaConfig is a void function throwing only exceptions so if statement does not work.
if ($this->isPrimaryReadReplicaConfigured($driver)) {
if($this->hasValidPrimaryReadReplicaConfig($driver)) {
$connection_configuration = (new PrimaryReadReplicaConnection($this->config, $connection_configuration))->resolve($driver);
}
}
Proposal:
if ($this->isPrimaryReadReplicaConfigured($driver)) {
$this->hasValidPrimaryReadReplicaConfig($driver);
$connection_configuration = (new PrimaryReadReplicaConnection($this->config, $connection_configuration))->resolve($driver);
}