Too easy to pass `extreme-variance`

[F-park]

Description

def f(a: list[int | str]):
    pass


def g(a: str | list):
    pass

Suggestion

Maybe we can use definition to make challenge strict.

[laike9m]

Could you clarify a bit on the modification?

[F-park]

Could you clarify a bit on the modification?

"""
TODO: Annotate function `foo`, to make tests pass.
"""
from collections.abc import Sequence


def foo(args: Sequence[int | str]):
    pass


## End of your code ##
foo(1)  # expect-type-error
foo("1")
foo(b"1")
foo([1, "2"])
foo(([1])  # expect-type-error
foo((1, "2", *(3 for _ in range(233))))
foo({1})  # expect-type-error

[laike9m]

Thanks! Tested it and it did solve the issue. I'll make a PR.

Also, I didn't know bytes is actually represented as a sequence of int, learned something new :)

[F-park]

It is still too easy to pass the challenge.

def f(a: list[int | str]):
    pass


def g(a: str | bytes | list | tuple):
    pass

---

Maybe we should add typeCheckingMode: "strict" to pyrightconfig.json and use tuple to make challenge strict.

g((1, "2", *(3 for _ in range(233))))

[laike9m]

Enabling strict mode would break other challenges, and I don't want to enable it since most people likely don't use it.

Thinking twice, the current checks are not perfect but should be good enough. g((1, "2", *(3 for _ in range(233)))) doesn't seem to provide much value? at least it doesn't guard against str | tuple | bytes | list.