compilation error TestTopicFactory
patriknw opened this issue · comments
Patrik Nordwall commented
cron builds against latest released Akka version
branch: 1.5.x
https://travis-ci.com/github/lagom/lagom/builds/189022491
[error] /home/travis/build/lagom/lagom/testkit/javadsl/src/main/scala/com/lightbend/lagom/internal/testkit/TestTopicFactory.scala:96:38: overloaded method value runWith with alternatives:
718[error] [M](sink: akka.stream.Graph[akka.stream.SinkShape[akka.Done],M], materializer: akka.stream.Materializer)M <and>
719[error] [M](sink: akka.stream.Graph[akka.stream.SinkShape[akka.Done],M], systemProvider: akka.actor.ClassicActorSystemProvider)M
720[error] cannot be applied to (akka.stream.javadsl.Sink[Nothing,java.util.concurrent.CompletionStage[akka.Done]], akka.stream.Materializer)
721[error] atMostOnceSource().via(flow).runWith(Sink.ignore(), materializer)
722[error] ^
Sergey Morgunov commented
Hmmm 🤔 Do we need to revert a backport of #3046 to 1.5.x
branch?
Patrik Nordwall commented
yes, please
I think we can remove the cron for testing 1.5.x with latest Akka. Almost no changes are done to Akka 2.5.x and similar with Lagom 1.5.x.
Sergey Morgunov commented
@patriknw I created PR. Will you remove a cron job for 1.5.x
in Travis? Or should I do it?
Renato Cavalcanti commented
This is fixed by #3060
And the cron job for 1.5.x
is removed