Make tolerance required on all methods that use it as an input argument
chriswmackey opened this issue Β· comments
There are a few places throughout this library where I used tolerance=0
in order to give a default value for tolerance but I've come to see this as bad practice and it should always be a required argument much like it is in Rhinocommon.
If we knew that this library were going to consistently get geometry at a particular scale and type of units, we could have set a non-zero default tolerance based on that, which is what I do in honeybee-core. But this library is intended to be agnostic towards specific applications of the geometry computation. And a tolerance of 0 is just impractical since Python floats can't abide by it. So making tolerance required seems like the best approach.
π This issue has been resolved in version 1.20.1 π
The release is available on:
- GitHub release
v1.20.1
Your semantic-release bot π¦π