Giters

labwc / labwc

A Wayland window-stacking compositor

Home Page:https://labwc.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

crash on Kill action with xwayland views

xi opened this issue · comments

commented

labwc crashes when I use the Kill action on xwayland views (tested with firefox, thunderbird, and xeyes). It does not crash on native wayland clients or when I manually call pkill -SIGTERM firefox.

commented

Hrm, right. We just kill the pid of the wayland client which in this case is xwayland itself.

So there are two issues here:

  • get the right pid (pid of the unix connection to the wayland socket for wayland native clients or ->pid for xwayland ones)
  • figure out why labwc is crashing when xwayland is killed and fix that
commented

Did look a bit more into this:

00:00:05.541 [../src/action.c:700] Sending SIGTERM to 2525860, we are 2525860

So we are not actually crashing, we just send a SIGTERM to ourselves.
This makes sense due to the way wlroots creates the xwayland connection: the fd that is used by xwayland to connect to labwc is created by socketpair() in wlroots, e.g. our own process.

I'll prepare a PR to fix this unless somebody else beats me to it.

commented

Thanks for the quick fix!