Descructors are never called in Unity Editor, so streams never get closed

Question

Descructors are never called in Unity Editor, so streams never get closed

jackbrookes opened this issue 3 years ago · comments

Dr Jack Brookes commented 3 years ago

For example, this line:

https://github.com/labstreaminglayer/liblsl-Csharp/blob/master/LSL.cs#L323

Is never called in the Unity Editor. Therefore, the stream stays alive after stopping playing.

I modified the code to manually close the stream, by adding a method:

        public void close_stream() { dll.lsl_destroy_outlet(obj); }

But when I call this, the next time I press play, it crashes the editor. Any way forward with this?

Dr Jack Brookes · Answer 1 · Wed Mar 03 2021 21:25:32 GMT+0800 (China Standard Time)

A solution is to re-open a stream with the same ID.

David Medine · Answer 2 · Tue Mar 30 2021 08:41:19 GMT+0800 (China Standard Time)

We currently have a pull request that adds an implementation of IDisosable.Dispose to all the LSL objects. This may (no promises) solve your problem. It will be a day or two before we finish merging, but I would suggest checking out the latest version once it's completed. I'd be curious to know if it does in fact help with your issue.

Chadwick Boulay · Answer 3 · Wed Mar 31 2021 10:53:45 GMT+0800 (China Standard Time)

@jackbrookes , with the merge of #10 I think your issue is now solved so I'm going to close it.
If you're still experiencing trouble then please let us know.