Do not throw ImproperlyConfigured error when custom Verify middleware is used
robmoorman opened this issue · comments
Rob Moorman commented
In order to use additional rules for verification (e.g. specify which user groups need 2fa), this line breaks custom middleware core.
Maybe better option to move this to the docs as an important rule that middleware is required, rather than at runtime when he app is loaded.
wagtail-2fa/src/wagtail_2fa/apps.py
Lines 19 to 22 in 76c3cf3
Nicole Nisters commented
This was fixed in pull request #31. It's now possible to use custom verify middleware. The exception is no longer raised, instead it's noted in the docs that the middleware has to be used.
Rob Moorman commented
Great @nnist !
Peter Dekkers commented
Fantastic, thank you.