kzkn / gretel

Flexible Ruby on Rails breadcrumbs plugin.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bootstrap4 not found + fragment_class: not working

JiriSubr opened this issue · comments

I tried to use style: :bootstrap4, but it throw error (could not find bootstrap4). Classic 3 :bootstrap works, i have latest 3.0.9 version.

I found the line where its defined: https://github.com/WilHall/gretel/blob/develop/lib/gretel/renderer.rb#L25

That's the first problem, which is not critical. You can evade it with manual settings.

So I just coppied settings:
container_tag: :ol, fragment_tag: :li, class: "breadcrumb", fragment_class: "breadcrumb-item", current_class: "active"

But library is ignoring fragment_class option, because it doesnt include class breadcrumb-item into fragment_tag li.

So now it's not possible to use it correctly in Bootstrap4 styles. Please fix, thanks.

Well i didn't realize that support for bootstrap4 and fragment_class tag was added, but not released yet. So if u have issues like me, just load the develop branch in your gemfile:
gem 'gretel', git: 'https://github.com/WilHall/gretel.git', branch: 'develop'

Maybe it should be added to Readme, because latest release version 3.0.9 is quite old.