kytos-ng / sdntrace_cp

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

feat: adapt code to support `dl_vlan` when it has a mask

viniarck opened this issue · comments

flow_manager is being updated to support dl_vlan value/mask on this issue kytos-ng/flow_manager#132

Related PR on flow_manager has just landed

Issue discussion regarding mask and payload is going on here for the record

@viniarck, Currently dl_vlan in flows supports mask, while dl_vlan in packet args is an integer into [1, 4095]. We shouldn't support a mask in the payload input, so this issue can be closed, right?

@viniarck, Currently dl_vlan in flows supports mask, while dl_vlan in packet args is an integer into [1, 4095]. We shouldn't support a mask in the payload input, so this issue can be closed, right?

That's correct @gretelliz, yes no mask in the input. Also, looking into unit test test_match_field_dl_vlan, it's also covering there, so the way it's converting and how the value is being passed looks good to me, feel free to close it.

Thank you!.