`self.M`, `self.N` should be deprecated in 1D and 2D
lostanlen opened this issue · comments
for consistency with 1D #857
we should rename self.M_padded and self.N_padded to self._M_padded and self._N_padded
same for 3D, self._O_padded etc.
What about 3d?
@MuawizChaudhary there is no padding in 3d, so the semantics are different.
the title self.O makes no sense then
@MuawizChaudhary the main goal of this was to allow non-power-of-two inputs in Scattering1D, in the prospect of JTFS. This goal is fulfilled now.
The longer-term goal is to allow shape=None (i.e., shape-agnostic scattering) in every dimension. This renaming helps a bit with the longer-term goal but we will need to have a debate in terms of how we name things.
- do we keep
self.N_padded,self.M_padded - do we join them as a single constant named
self._shape_paddedin every dimension - if so, is there a shorter name for
self._shape_padded - how does this interact with #859
these are all questions worth asking between v0.3 and v0.4