Giters

kyma-project / hydroform

Infrastructure SDK for provisioning and managing Kubernetes cluster based on Terraform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Function is unchanged when label or annotation change.

dbadura opened this issue · comments

commented

Description
When user add label or annotation to function, the sdk says that the object is the same, but it's not.

Expected result
When function is applied with changed label or annotations, the hydroform updates the labels or annotations.

Actual result
Currently the labels and annotations are not detected as change.
The faulty code is here: https://github.com/kyma-project/hydroform/blob/main/function/pkg/operator/operator.go#L41=

Steps to reproduce

  1. Use kyma cli and init basic function: kyma function init
  2. Apply function: kyma function apply .
  3. Add any label to config.yaml, for example:
labels:
  aa: bb
  1. apply changes: kyma function apply

The cli will report that the function didn't change, but it's not true.

Troubleshooting

commented

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale