An in-range update of redux is breaking the build 🚨
greenkeeper opened this issue · comments
Version 3.7.0 of redux just got published.
| Branch | Build failing 🚨 |
|---|---|
| Dependency | redux |
| Current Version | 3.6.0 |
| Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As redux is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Status Details
Release Notes
v3.7.0Another long break!
Oh, hey! I didn't see you sitting there. You look bored. How about a Redux release to spice things up?
Not a huge set of changes to report here. The biggest change, and the reason for the minor bump, is the UMD build is now done via Rollup. One big advantage is more readable code in the bundle. Rollup does "scope hoisting", which is a fancy term for putting every module at the top level of the file. Other than a surrounding IIFE, all of the code in Redux all lives together. You can compare the two here:
Rollup UMD build
vs
Webpack UMD build
There is also a cost savings of 30,811 vs 26,880 bytes, and 6,999 vs 5,995 bytes minified. Redux is already a small library, and this helps shave some extra bytes for our UMD users.
One thing to note is that Webpack has introduced it's own scope hoisting feature in 3.0 beta. So, this isn't intended as an indictment of Webpack. You should continue to use it in your own apps. The adage of "Webpack is for apps, Rollup is for libraries" definitely holds true. It still has a superior developer experience with hot module reloading and webpack-dev-server. But use whatever makes sense for your project, not just whatever we use. 😄
We're also looking at applying this to the NPM bundle. The main motivation is again more readable code in your bundles. Instead of transpilation oddities from Babel, you will end up with a single clean file, which should be easier to read through and debug. It's currently scheduled for the big, mythical 4.0 release and you can follow along in #2358
Changes
- Build UMD with rollup (#2283 by @TrySound)
- Warn when bindActionCreators encounters non-function property (#2279 by @artgillespie)
- Update variables to ES6 (#2169 by @dfrownfelter)
- Remove filtering inside compose (#2167 by @istarkov)
- Simplify compose (#2147 by @JoeCortopassi)
Commits
The new version differs by 309 commits.
2d229f03.7.0f3bba96Removing the browser field for nowf4d9e55Upgrade all example deps, including the universal example to Webpack 22bc8f84Upgrade some other deps070b838Upgrades and remove check-es3-syntax since Rollup breaks it always1094724Fix a typo in the Immutable.js docs (#2453)bf3a557Fix redux-mock-store libdef for todos-flow (#2430)bf2b9b5give redux-subscriber some attention in StoreSetup.md (#2433)8b3e0cbsyncing docs with recent PR (2431) (#2432)e238a19'todo' const removal from reducers/todos.js (#2431)0babfabMerge pull request #2429 from alexbaumgertner/bugfix/doc-linkae563c3Fix link to ImmutableData article383215aUpdate redux.js (#2428)c9ad6a4Add 100% test coverage for todos-flow example (#2413)ea16d76Fix eslint warnings, update react-scripts (#2420)
There are 250 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
After pinning to 3.6.0 your tests are passing again. Downgrade this dependency 📌.