incompatible with NDMF 1.3.0-rc.6 or later
anatawa12 opened this issue · comments
Describe the bug
A clear and concise description of what the bug is.
コンパイルエラーが発生します。
Packages/com.github.kurotu.vrc-quest-tools/Editor/NDMF/NdmfComponentRemoverWarning.cs(22,38): error CS0507: 'NdmfComponentRemoverWarning.Localizer': cannot change access modifiers when overriding 'public' inherited member 'SimpleError.Localizer'
Packages/com.github.kurotu.vrc-quest-tools/Editor/NDMF/NdmfComponentRemoverWarning.cs(24,35): error CS0507: 'NdmfComponentRemoverWarning.TitleKey': cannot change access modifiers when overriding 'public' inherited member 'SimpleError.TitleKey'
Packages/com.github.kurotu.vrc-quest-tools/Editor/NDMF/NdmfComponentRemoverWarning.cs(26,35): error CS0507: 'NdmfComponentRemoverWarning.DetailsKey': cannot change access modifiers when overriding 'public' inherited member 'SimpleError.DetailsKey'
Packages/com.github.kurotu.vrc-quest-tools/Editor/NDMF/NdmfComponentRemoverWarning.cs(28,37): error CS0507: 'NdmfComponentRemoverWarning.DetailsSubst': cannot change access modifiers when overriding 'public' inherited member 'SimpleError.DetailsSubst'
To Reproduce
Steps to reproduce the behavior:
- install com.github.kurotu.vrc-quest-tools 2.1.1
- install NDMF 1.3.0-rc.6
Expected behavior
No Compilation Error
Screenshots
If applicable, add screenshots to help explain your problem.
Console log
See above
Used assets
No other assets
Environment
- VRCQuestTools version 2.1.1
- Unity 2019.4.31f1
- NDMF 1.3.0-rc.6
Additional context
Add any other context about the problem here.
VersionDefinesでVQT_HAS_NDMF_ERROR_REPORT
の定義条件のexpressionが1.3.0-rc.0
になってますが、これではx >= 1.3.0-rc.0
となってしまい、2.0.0や将来のrcバージョンで壊れてしまいます。
プリリリース版では破壊的変更が発生することがあるので、[1.3.0-rc.0]
(== 1.3.0-rc.0
を意味する) のようにバージョンを厳しく固定するべきだと思います。