kulakowka / feathers-validate-hook

Feathers hook for validate json-schema with is-my-json-valid

Home Page:https://code-typing-tutor.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dont wrap schema

psi-4ward opened this issue · comments

Hi,

why do you wrap given Schema ?

So i can not add additional Schema stuff like additionalProperties, definitions or even patternProperties.

Perhaps we could only wrap it if the source-schema Obj does not include a properties prop?

Thought the same. But I would remove https://github.com/kulakowka/feathers-validate-hook/blob/master/lib/validate/index.js#L8-L12
The developer should be responsible for providing the correct schema.

@kulakowka What do you think? I could create a pr if you want

@sean-nicholas I'll be very happy;

@kulakowka Oh, I see you fixed it already 😄 So I think we can close this issue.

ezoic increase your site revenue