kucharovic / money-bundle

Symfony bundle providing integration for Money library.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Longer currency codes

danaki opened this issue · comments

Cryptocurrencies for example MIOTA or WAVES have codes longer than 3 symbols, this number is hardcoded in money-bundle/Resources/config/doctrine/Currency.orm.xml.

Length of currency code is according to ISO 4217 standard. If you need support of longer symbols, make a pull request, please.

There's no reason to stick to this standard in underlying database layer like doctrine, since MoneyPhp supports cryptocurrencies too which do not respect any standards.

Agreed, send a PR.