kubeadm: add note about a bug in the PublicKeysECDSA feature gate
neolit123 opened this issue · comments
in this PR we changed the main branch with a certain kubeadm note:
#46795
we need to do the same now for the dev-1.31 branch and a slightly different note.
please /assign yourself if you want to work on this ticket.
steps for dev-1.31
- create a new branch from the
dev-1.31branch. - modify this page:
content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md - include this note in a new sentence:
Kubernetes versions before v1.31 had a bug where keys in generated kubeconfig files were set use RSA,
even when you had enabled the `PublicKeysECDSA` feature gate.
in the description for PublicKeysECDSA
- send a PR and type
xref #46799in its description, make sure it targets the correct branch
steps for release-1.29, release-1.28, release-1.27 to release-1.26
- create a new branch from the
release-x.xxbranch that you want to target. - modify this page:
content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md - include this note in a new sentence:
Kubernetes {{< skew currentVersion >}} has a bug where keys in generated kubeconfig files are set use RSA
despite the feature gate being enabled.
in the description for PublicKeysECDSA
- send a PR and type
xref #46799in its description, make sure it targets the correct branch
notify us that the PRs are ready with a comment.
/help
/sig cluster-lifecycle
@neolit123:
This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
in this PR we changed the main branch with a certain kubeadm note:
#46795we need to do the same now for the dev-1.31 branch and a slightly different note.
please/assignyourself if you want to work on this ticket.steps:
- type
/assignin a comment here- create a new branch from the
dev-1.31branch.- modify this page:
content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md- include this note in a new sentence:
Kubernetes versions before v1.31 had a bug where keys in generated kubeconfig files were set use RSA, even when you had enabled the `PublicKeysECDSA` feature gate.in the description for
PublicKeysECDSA
- notify us that the PR is ready with a comment
/help
/sig cluster-lifecycle
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/good-first-issue
/triage accepted
cc @sftim please apply edits to the description if needed.
xref #46795 (review)
also note that this is not a high priority feature for kubeadm so the backport part maybe can be skipped.
/assign
@neolit123 Hi mate,
The PRs are already for review. I also found an issue in that the PR for dev-1.26 failed. I can't come up with the reason why the workflow failed. If you don't mind, give it a look when you have time.
For releases that have already happened, these changes should actually be made to release-* not dev-*.
@neolit123 I will
/remove-good-first-issue
because the PR description may confuse a newcomer. Help is still welcome.
For releases that have already happened, these changes should actually be made to
release-*notdev-*.
updated the description.
..well that already confused me.
@SequoiaGod seems branches need to be updated.
For releases that have already happened, these changes should actually be made to
release-*notdev-*.updated the description. ..well that already confused me.
@SequoiaGod seems branches need to be updated.
Yup, thanks for your help. I will update my code later today.
-steps for release-1.29, dev-1.28, dev-1.27 to dev-1.26
+steps for release-1.26 to release-1.29I think
Got it, will amend it later.
@neolit123 Hi mate, PRs have already opened for review. Thank you so much for your supporting.
@neolit123 Hi mate, PRs have already opened for review. Thank you so much for your supporting.
thanks added LGTM. the docs owners must approve your PRs.
all PRs merged. please reopen if needed.
thanks