Update OWNERS files to suggest the appropriate approvers
Okabe-Junya opened this issue · comments
This is a Feature Request
Update OWNERS files so that the appropriate approvers are suggested (by prow) when creating a PR
Why is this needed
When creating a PR to localize, prow now recommends members of sig-docs-website-owners as approvers. This often confuses contributors (and the assigned approvers will also be confused).
e.g., #46240 is a Japanese l10n PR, so we want to suggest sig-docs-ja-owners to approve. but, divya-mohan0209 is not a Japanese l10n reviewer/approver, but Website Owner
Therefore, I want to update the OWNERS files so that l10n approvers are suggested.
Comments
ref. https://kubernetes.slack.com/archives/C1J0BPD2M/p1715794626564569
This issue is currently awaiting triage.
SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/sig docs
/sig testing
/sig contributor-experience
/help
/assign
/remove-help
Note that the recommendation algorithm to suggest approvers in prow checks the OWNERS files near the changed files.
FYI: https://pkg.go.dev/sigs.k8s.io/prow/pkg/plugins/approve/approvers#Approvers.GetCCs
This only uses leaf approvers to find the closest approvers to the changes.
so, We need to remove sig-docs-website-owners entry from each CODEOWNERS files exclude root