Drop archived vendored libraries and switch to active ones
dims opened this issue · comments
- github.com/google/gofuzz (Archived Jan 10, 2024)
- github.com/google/shlex (Archived Dec 29, 2022)
- github.com/gregjones/httpcache (Archived Apr 20, 2023)
- github.com/grpc-ecosystem/go-grpc-prometheus (Archived Apr 18, 2023, Alternative - https://github.com/grpc-ecosystem/go-grpc-middleware/tree/main/providers/prometheus)
- github.com/pkg/errors (Archived Dec 1, 2021, Switch to golang errors)
Follow up to #120276
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:
/sig <group-name>/wg <group-name>/committee <group-name>
Please see the group list for a listing of the SIGs, working groups, and committees available.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
This issue is currently awaiting triage.
If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
"github.com/grpc-ecosystem/go-grpc-prometheus" is only from etcd.
issue already filed xref - etcd-io/etcd#17883
"github.com/pkg/errors" is there in our code, so we should deal with it first. There are lots of hits in kubeadm ( cc @pacoxu and @neolit123 )
shlex seems to be only from kustomize:
❯ rg "google/shlex" | grep "\.go"
vendor/sigs.k8s.io/kustomize/api/internal/plugins/execplugin/execplugin.go: "github.com/google/shlex"
"github.com/pkg/errors" is there in our code, so we should deal with it first. There are lots of hits in kubeadm ( cc @pacoxu and @neolit123 )
yeah, this was discussed before. the repo is unmaintained but it's not insecure. if we can continue using - great. if we cannot, we are going to fork it under cmd/kubeadm.
we need that stack tracing, consistent wrapping and error formating. just fmt.Error with %w is not a replacement.