Compatibility between `k8s.io/component-base` and latest `go.opentelemetry.io/otel/exporters/prometheus`.
angelokurtis opened this issue · comments
What would you like to be added?
I would like k8s.io/component-base to be compatible with the latest version of go.opentelemetry.io/otel/exporters/prometheus.
Why is this needed?
In version 0.48.0 of the github.com/prometheus/common library, the expfmt.FmtText constant was made private. This directly impacts its compatibility with k8s.io/component-base, which uses this constant, leading to issues with the latest Prometheus libraries, such as go.opentelemetry.io/otel/exporters/prometheus.
/sig instrumentation
you can try contacting https://github.com/kubernetes/community/tree/master/sig-instrumentation
/assign @shiva1333 @rexagod
/triage accepted
@dgrisonnet: GitHub didn't allow me to assign the following users: shiva1333.
Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide
In response to this:
/assign @shiva1333 @rexagod
/triage accepted
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@angelokurtis Could you link to where this is being used in component-base? I did a search but it came up empty.
It appears that the issue was resolved in #124346 and will be included in v1.31
/close
Sounds good, closing this then.
@rexagod: Closing this issue.
In response to this:
/close
Sounds good, closing this then.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.