Investigate support for multiple route tables
aoxn opened this issue · comments
Problem Description
Many Cloud support multiple route tables under VPC. CCM Cloud Interface has poor support for multi-route tables. Consider ListRoutes() interface, It is confused for ListRoutes() to return which route tables`s entry.
For example, RouteTableA has route entry [1,2,3,4], RouteTableB has route entry [2,3,4,5]
What result should ListRoutes() return? Neither [1,2,3,4,5] nor [2,3,4] is good. For case [1,2,3,4,5] , CreateRoute() would not be called for entry [1] and [5] which is needed.
For case [2,3,4] Delete() would not be called for the similar reason.
Potential Solutions
-
Modify exist Interface,
ListRoutes(tableid string). Add interface AllRouteTables() []Tables -
ListRoute() randomly return each route-table once a time. Reconcile would make sure the eventually consistency for route tables.
/assign @andrewsykim
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
@aoxn what's the use-case for multiple route tables?
The background is that CCM goes wrong when user has multiple routetalbes under their VPC. Because the default ccm behavior is to write the 0th route table which would not be the target(route table).
Alibaba Cloud use a self defined controller extended cloudprovider interface to solve this issue for now. It might be better to solve it in cloudporivder interface level as other provider may face the same problems.
ping @aoxn what's the status of this for v1.17?
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
@andrewsykim I am afraid a new Interface would be add in order to support multiple routetables
// Routes is an abstract, pluggable interface for advanced routing rules.
type Routes interface {
// RouteTables get all available route tables.
RouteTables(clusterName string) ([]string, error)
// ListRoutes lists all managed routes that belong to the specified clusterName
ListRoutes(clusterName string, table string) ([]*cloudprovider.Route, error)
// CreateRoute creates the described managed route
// route.Name will be ignored, although the cloud-provider may use nameHint
// to create a more user-meaningful name.
CreateRoute(clusterName string, nameHint string, table string, route *cloudprovider.Route) error
// DeleteRoute deletes the specified managed route
// Route should be as returned by ListRoutes
DeleteRoute(clusterName string, table string, route *cloudprovider.Route) error
}
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.