replace deprecated methods
googs1025 opened this issue · comments
Area
- Scheduler
- Controller
- Helm Chart
- Documents
Other components
No response
What happened?
I see that the wait.Poll
method is still widely used in unit tests and integration tests. This method has been deprecated in favor of PollUntilContextTimeout
.
We should replace this method
// Deprecated: This method does not return errors from context, use PollUntilContextTimeout.
// Note that the new method will no longer return ErrWaitTimeout and instead return errors
// defined by the context package. Will be removed in a future release.
func Poll(interval, timeout time.Duration, condition ConditionFunc) error {
return PollWithContext(context.Background(), interval, timeout, condition.WithContext())
}
What did you expect to happen?
replace Poll
method to PollUntilContextTimeout
How can we reproduce it (as minimally and precisely as possible)?
No response
Anything else we need to know?
No response
Kubernetes version
None
$ kubectl version
# paste output here
Scheduler Plugins version
None
/kind cleanup
/assign