Giters

kubernetes-sigs / controller-runtime

Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Semantic version is incorrect for setup-envtest

mlhamel opened this issue · comments

commented

For setup-envtest there's a change that introduced at 4c2442e but it seems the version of was changed to 1.22.0 but it doesn't follow semantic versioning and crash while updating packages:

It should be 1.22 at https://github.com/kubernetes-sigs/controller-runtime/blob/main/tools/setup-envtest/go.mod#L3

commented

There have been a few issues and PRs about this before.

The tldr is, no the format is correct. Please either use Go 1.22 or pin setup envtest to release-0.17

commented

thanks @sbueringer, i'm closing the issue cause yeah it seems the issue was on my end.

commented

It doesn't help that some Go versions are returning wrong error messages :) (i.e. that the version should be major.minor instead of major.minor.patch)