Consider returning warnings in validation for usage of deprecated fields
chrischdi opened this issue · comments
What would you like to be added (User Story)?
As a user I would like to get a warning when I make use of deprecated fields.
Detailed Description
We already have some deprecated fields:
-
Cluster.spec.topology.rolloutAfter
-
DockerMachine.spec.bootstrapped
-
ClusterClass.spec.Variables[].Metadata
? - https://github.com/kubernetes-sigs/cluster-api/issues/104790
- #10666
- #10778
- experimentalRetryJoin
- ...
and considering e.g.:
we may introduce more in future.
For providing a user the information that it makes use of a deprecated field, we could use warnings in validation to bubble that information up.
Anything else you would like to add?
No response
Label(s) to be applied
/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
/triage accepted
/help
we can evaluate case by case on follow up PRs
@fabriziopandini:
This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help
command.
In response to this:
/triage accepted
/helpwe can evaluate case by case on follow up PRs
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Yup also
- Consider deprecation of revision management in MachineDeployments #10479
- Deprecated definitionFrom in cluster variables #10666
- ✨ Add metadata for top-level and nested variables & deprecate previous metadata field #10778
- experimentalRetryJoin
I think this is a great idea, and we should do this for all fields now & going forward
moved these up to the list