Gitlab repository: support both the project ID and the escaped full path
aetertinas9 opened this issue · comments
What steps did you take and what happened?
This is a bug that occurred in the above link and has not been resolved for a long time. However, it needs to be included in the release version, so I am opening a new issue.
What did you expect to happen?
Using GitLab as per the docs, it supports both the project ID and the escaped full path.
Cluster API version
release version
Kubernetes version
v1.28.4
Anything else you would like to add?
Thanks :)
Label(s) to be applied
/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
This issue is currently awaiting triage.
If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
sorry it's my first PR
Q: is this issue + related PR a replacement of #9481?
Can we close it?
@fabriziopandini
That's correct. I also opened this issue because of the same problem with not being able to use the GitLab URL properly. Instead of using the url.Path, this supports both the escaped full path and project ID as per the official documentation.
/priority backlog
I think those kind of errors boils up to the fact that we don't have a good test coverage for all the supported use cases.