Metrics for SSA cache
sbueringer opened this issue · comments
A while ago we implemented a ssa.Cache to cache SSA calls. I think it would be great if we have corresponding metrics (e.g. cache hit/miss) so we can observe how well the cache is working.
We should at least have labels for:
- the object of the SSA call (probably just kind)
- the controller in which the cache is used (MD / MS / cluster topology / ...)
I think we'll have to extend the cache a bit to have the data for the labels.
Also let's take a look at how cache metrics usually look like in the Prometheus format and try to be consistent with that.
This issue is currently awaiting triage.
CAPI contributors will take a look as soon as possible, apply one of the triage/* labels and provide further guidance.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
(cc @chrischdi as you showed interest in that topic)
/kind feature
/priority important-longterm