kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack

Home Page:https://cluster-api-openstack.sigs.k8s.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

We don't test clusterctl move

mdbooth opened this issue · comments

/kind bug
clusterctl move does not copy object status. While we are probably ok with the new state fields in OpenStackMachine (and the bastion) because we considered upgrade where they were not previously set, we should certainly test this.

CAPI's SelfHostedSpec exercises this: https://github.com/kubernetes-sigs/cluster-api/blob/ec900f852f8dc45887a4972632b789176ab6ec08/test/e2e/self_hosted.go#L42

We should implement this as soon as possible.

I'm pretty sure we do test this in the optional suite! I'm after all the one who added it 😅
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/test/e2e/suites/e2e/self_hosted_test.go

Well that came to a rapid conclusion 😎