Giters

kubernetes-retired / multi-tenancy

A working place for multi-tenancy related proposals and prototypes.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

HNC: find a new way to test unpropagatable objects

adrianludwin opened this issue · comments

commented

Since #1489, HNC has been able to propagate cluster-admin rolebindings and therefore the test for #328, #605 and #771 have broken. We need to find another way to stop HNC from propagating these objects, possibly by having some special-purpose test webhook or something.

commented

Another possible way to do it:

  • Create a Role in the parent and forbid it from being propagated
  • Create a RoleBinding in the parent

Usually, RBs cannot be created with the Roles they refer to existing first, so this should cause an error.

commented

/good-first-issue

commented

@adrianludwin:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

commented

@adrianludwin: Closing this issue.

In response to this:

Replaced by kubernetes-sigs/hierarchical-namespaces#13

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.