HNC: non json logs
seankhliao opened this issue · comments
With logging output in JSON, I was expecting all of the log output to actually be in JSON but it appears some of them are not captured, see below.
I believe these can be wrapped in json by redirecting the standard library's default logger output
{"level":"error","ts":1614332075.2494884,"logger":"controller","msg":"Reconciler error","reconcilerGroup":"hnc.x-k8s.io","reconcilerKind":"HNCConfiguration","controller":"hncconfiguration","name":"config","namespace":"","error":"Internal error occurred: failed calling webhook \"hncconfigurations.hnc.x-k8s.io\": Post https://hnc-webhook-service.hnc-system.svc:443/validate-hnc-x-k8s-io-v1alpha2-hncconfigurations?timeout=30s: no endpoints available for service \"hnc-webhook-service\""}
2021/02/26 12:23:22 http: TLS handshake error from 172.16.0.6:39660: EOF
2021/02/26 21:02:15 http: TLS handshake error from 172.16.0.6:47842: EOF
2021/02/26 21:33:31 Failed to export to Stackdriver: rpc error: code = DeadlineExceeded desc = One or more TimeSeries could not be written: Deadline expired before operation could complete.: timeSeries[0-6,8]
{"level":"info","ts":1614375267.5580504,"logger":"cert-rotation","msg":"no cert refresh needed"}
2021/02/26 21:34:31 Failed to export to Stackdriver: rpc error: code = DeadlineExceeded desc = One or more TimeSeries could not be written: Deadline expired before operation could complete.: timeSeries[0-8]
/good-first-issue
Thanks @seankhliao . Would you have the chance to make a PR for this?
@adrianludwin:
This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/good-first-issue
Thanks @seankhliao . Would you have the chance to make a PR for this?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.