HNC: document that some E2E tests cannot run with Hierarchy Controller

Question

HNC: document that some E2E tests cannot run with Hierarchy Controller

GinnyJI opened this issue 4 years ago · comments

Before running E2E test suite, Hierarchy Controller has to be uninstalled first, otherwise any test that needs HNC_REPAIR will cause problems. I don't know if and how we should document this.

Adrian Ludwin commented 3 years ago

/assign

Ginny · Answer 1 · Wed Dec 02 2020 03:04:26 GMT+0800 (China Standard Time)

/cc @adrianludwin
/assign @GinnyJI

Adrian Ludwin · Answer 2 · Wed Dec 02 2020 04:45:27 GMT+0800 (China Standard Time)

We already print a big warning if HNC_REPAIR is _not_ set. Maybe if HNC_REPAIR _is_ set, we need to print a big warning saying "Make sure HNC isn't being managed by an operator (like ACM or Config Sync) since we're about to make changes to it!" followed by a 5s delay so that you can ctrl-c your way out of it?

…

On Tue, Dec 1, 2020 at 2:04 PM Ginny ***@***.***> wrote: /cc @adrianludwin <https://github.com/adrianludwin> /assign @GinnyJI <https://github.com/GinnyJI> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1295 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE43PZDCVE4M627WZUVTEXLSSU44TANCNFSM4UJMY4NQ> .

fejta-bot · Answer 3 · Mon Mar 15 2021 04:36:03 GMT+0800 (China Standard Time)

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

Yiqi Gao · Answer 4 · Tue Mar 16 2021 22:58:08 GMT+0800 (China Standard Time)

/remove-lifecycle stale

Adrian Ludwin · Answer 5 · Wed Apr 28 2021 00:00:50 GMT+0800 (China Standard Time)

Fixed by #1487
/close

Kubernetes Prow Robot · Answer 6 · Wed Apr 28 2021 00:00:56 GMT+0800 (China Standard Time)

@adrianludwin: Closing this issue.

In response to this:

Fixed by #1487
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.