A list of actions instead of hacky string spliting on schedulerConf

Question

A list of actions instead of hacky string spliting on schedulerConf

edwardstudy opened this issue 4 years ago · comments

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

actions: "allocate, backfill"
tiers:
- plugins:
  - name: priority
  - name: gang
- plugins:
  - name: drf
  - name: predicates
  - name: proportion
  - name: nodeorder

https://github.com/kubernetes-sigs/kube-batch/blob/519821ef8ed04232a5f471c1b547de592082c71d/pkg/scheduler/util.go#L32-L41

We had a string to define actions. Why not use list like tiers.

What you expected to happen:
schedulerConf becomes:

actions:
- allocate
- backfill
tiers:
- plugins:
  - name: priority
  - name: gang
- plugins:
  - name: drf
  - name: predicates
  - name: proportion
  - name: nodeorder

How to reproduce it (as minimally and precisely as possible):
None

Anything else we need to know?:
None
Environment:

Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:
None

fejta-bot · Answer 1 · Wed Nov 04 2020 23:38:50 GMT+0800 (China Standard Time)

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · Answer 2 · Sat Dec 05 2020 00:23:28 GMT+0800 (China Standard Time)

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · Answer 3 · Mon Jan 04 2021 01:08:49 GMT+0800 (China Standard Time)

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Kubernetes Prow Robot · Answer 4 · Mon Jan 04 2021 01:08:56 GMT+0800 (China Standard Time)

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.