WithStopSignals has bug?

[neoli]

It seems WithStopSignals just adds a new stop signal, other existed stop signals are not canceled.

graceful.WithStopSignals([]syscall.Signal{syscall.SIGKILL})
after setting stop signal to SIGKILL, SIGTERM and SIGINT can still stop the server.

I add this to avoid this problem
signal.Ignore(syscall.SIGTERM, syscall.SIGINT)

[Changlang Kuang]

Hi @lpy-neo , WithStopSignals registers signals for handling server graceful shutdown, other unregistered signals are not shielded, which will still work as default behavior, such as SIGTERM will kill the process.
Ignore signals manually on your scenario should be the proper way, WithStopSignals is not well named and documented.

[neoli]

@kuangchanglang Thanks for your reply.
By the way, as SIGKILL can't be caught, so it may be more helpful (to the newbies) to point out this fact. Because it seems WithStopSignals(SIGKILL) can do graceful stopping work.