ktomk / pipelines

Pipelines - Run Bitbucket Pipelines Wherever They Dock

Home Page:https://ktomk.github.io/pipelines/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

coverage-checker.php deprecated notice

bkdotcom opened this issue · comments

$xml->xpath(".//metrics/@${s}elements")

PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in .../coverage-checker.php on line 53

needs to be either
$xml->xpath('.//metrics/@' . $s . 'elements')
or
$xml->xpath(".//metrics/@{$s}elements")

Thanks for reporting, version 0.0.70 has this now in (+ a couple of other places), see change log (0.0.70).

What follows is only for reference, I close the issue, feel free to re-open if there is anything about it.


PHP 8.2 Deprecate ${} string interpolation (Created on 2021-03-13)

  • Using ${} in strings is deprecated
  • Using ${} (variable variables) in strings is deprecated (“${expr}”, equivalent to (string) ${expr}), e.g. return empty string but do something in expr