SponsorBlock segments misaligned
zulc22 opened this issue · comments
also the added SponsorBlock icons don't fit the theming of the player
Working on this right now.
Fixed in latest update on dev branch. Might want to figure out a simpler way to detect specific plugins, but this should do for now.
Forgot to import the CSS file that fixes this, 1.3dev2 fully fixes this issue.
Still not 100% fixed (switched to dev branch) -- the segments are no longer misaligned when the bar is small, but they don't expand with the bar like they had before the fix, meaning when the bar is expanded they again appear misaligned.
Ok so I just figured out why that happens.
Since the ui class named previewbar (created by SponsorBlock) is inside of the ytp-progress-bar-container, changing the pointer-events from none to anything else causes the progress bar not extending but the scrubber appears??
So by moving previewbar from ytp-progress-barcontainer to something like ytp-progress-bar it fixes the stupid issue with the progress bar and scrubber doing weird things AND extends previewbar when hovering over the progress bar!
Before:
After:
Why did SponsorBlock do this? Don't know -- going to get a fix out on the dev branch soon for this, prob going to involve some JS. (In the future I should be less lazier than I am)
Fully fixed in 1.3dev3 (hopefully for good this time)